Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix require_literal_leading_dot flipped behavior #7227

Merged
merged 2 commits into from
Jun 17, 2023
Merged

fix(core): fix require_literal_leading_dot flipped behavior #7227

merged 2 commits into from
Jun 17, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Jun 17, 2023 •
edited
Loading

Regression introduced in: #6969 see #6969 (comment)

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner June 17, 2023 00:59
@amrbashir amrbashir requested a review from tweidinger June 17, 2023 01:02
@amrbashir amrbashir force-pushed the fix/core/require-leading-dot branch from de63c29 to 75d61d5 Compare June 17, 2023 11:27
@lucasfernog lucasfernog merged commit 066c09a into 1.x Jun 17, 2023
@amrbashir amrbashir deleted the fix/core/require-leading-dot branch June 17, 2023 12:25
amrbashir added a commit that referenced this pull request Jun 17, 2023
@amrbashir
fix(core): fix require_literal_leading_dot flipped behavior (#7227)
8e87c9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

@wusyong wusyong wusyong approved these changes

@tweidinger tweidinger Awaiting requested review from tweidinger

Assignees
No one assigned
Labels
None yet
Projects
Roadmap
Status: 🔎 In audit
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amrbashir @wusyong @lucasfernog